Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update annex meeting when updating normal meeting #2283

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

sergiofenoll
Copy link
Member

https://kanselarij.atlassian.net/browse/KAS-4946

When updating a meeting, update any annex meetings if they exist. Show a toast when this is the case.

Copy link
Contributor

@ValenberghsSven ValenberghsSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, ticket is fulfilled but wondering if we should also update the meeting number.

Comment on lines +314 to +318
this.toaster.success(this.intl.t('annex-meeting-was-saved', {
title: annexMeeting.numberRepresentation,
timeout: 10000,
}));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longer timeout but closable? Like how we did the decisions updated pop-up maybe

Comment on lines +307 to +308
annexMeeting.plannedStart = this.args.meeting.plannedStart;
saveActivities.push(annexMeeting.save());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked in the jira ticket.
Another thing we may want to change is the number.
that is also not editable on annex meetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants